Dev UI: always produce JsonRPCProvidersBuildItem #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to an upcoming change in Execution Model Validation [1] where we need the `JsonRPCProvidersBuildItem` produced always, not only in dev mode. JSON RPC providers can use execution model affecting annotations, so we need to know about them, otherwise a non-dev build would fail with an incorrect validation error. [1] quarkusio/quarkus#46965
ricardozanini
approved these changes
Mar 25, 2025
Contributor
|
@ricardozanini @fjtirado can you do a release. Without this Quarkus 3.23.0 is giving this stack trace... |
Member
|
@melloware main is on 3.15.x thou: https://github.com/quarkiverse/quarkus-embedded-postgresql/blob/main/pom.xml#L30 Is that alright? We are not planning to push the Quarkus version atm. |
Contributor
|
Correct I think you just need to publish as is with the fix already merged from @Ladicek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to an upcoming change in Execution Model Validation [1] where we need the
JsonRPCProvidersBuildItemproduced always, not only in dev mode. JSON RPC providers can use execution model affecting annotations, so we need to know about them, otherwise a non-dev build would fail with an incorrect validation error.[1] quarkusio/quarkus#46965