remove Node from python api #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-visualizer-files Add visualization library to CMake build
…-and-fix-cmake-tests Fix CMake Python module path and add agent build instructions
…accept-bitstring Allow decode_to_errors to accept bitstring
Co-authored-by: Noureldin <noureldinyosri@gmail.com>
…date-tesseract Add explicit DetIndex branch for detector ordering
…ers-and-build_det_orders refactor detector order helpers
The Node struct is an internal implementation detail of the C++ tesseract library and should not be exposed in the Python API. This commit removes the pybind bindings for the Node struct and also removes the corresponding test case from the Python tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node is just a C++ implementation detail which does not need to be exposed to the python user (I think)
overall trying to simplify and clean things up so that we can iterate more easily on the algorithm