refactor of det order helper functions and tests #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
noajshu
commented
Aug 29, 2025
noajshu
commented
- added better test for index-based ordering
- refactored the det order function so it uses smaller helpers and a switch statement
…e-visualizer-files Add visualization library to CMake build
…-and-fix-cmake-tests Fix CMake Python module path and add agent build instructions
…accept-bitstring Allow decode_to_errors to accept bitstring
Co-authored-by: Noureldin <noureldinyosri@gmail.com>
…date-tesseract Add explicit DetIndex branch for detector ordering
…ers-and-build_det_orders refactor detector order helpers
Contributor
Author
|
Also updated beam climbing behavior to do the max of (beam+1, num_det_orders) # trials |
LalehB
approved these changes
Aug 30, 2025
Collaborator
LalehB
left a comment
LalehB
left a comment
There was a problem hiding this comment.
LGTM!
Thanks Noah, this is pretty cool!
| size_t cur = q.front(); | ||
| q.pop(); | ||
| auto neigh = graph[cur]; | ||
| std::shuffle(neigh.begin(), neigh.end(), rng); |
Collaborator
There was a problem hiding this comment.
I wonder why we are shuffling here? 🤔
Contributor
Author
There was a problem hiding this comment.
Ah, this is to generate diversity in the ensemble!
| return build_det_orders_index(dem, num_det_orders, rng); | ||
| } | ||
| throw std::invalid_argument("Unknown det order method"); | ||
| } |
Collaborator
There was a problem hiding this comment.
I wonder if we should have one of them as default 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.