-
Notifications
You must be signed in to change notification settings - Fork 17
Refactor det order creation, restore optional index-based det ordering #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-visualizer-files Add visualization library to CMake build
…-and-fix-cmake-tests Fix CMake Python module path and add agent build instructions
…accept-bitstring Allow decode_to_errors to accept bitstring
Co-authored-by: Noureldin <noureldinyosri@gmail.com>
…date-tesseract Add explicit DetIndex branch for detector ordering
oscarhiggott
approved these changes
Aug 29, 2025
Contributor
oscarhiggott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the paper we used detector indices to sort them and make the det orders. This was actually an accident where we were trying to use the 3d coordinates (xyt) from Stim but used Stim incorrectly (my bad).
This got fixed in a77f5e7 where we started using the actual xyt coordinates.
This seems to offer a better tradeoff between beam and error rate, but also led to issue #103 because at the same large beam we get worse performance (likely because there are more distinct orderings which means more ways to get stuck)
We also added BFS det ordering in bf62f84 and then made it the default in 0471d4e
Unfortunately due to a bug in p-ranav's argparse: p-ranav/argparse#413
flags with implicit_value(false) do not work with store_into, which means the
--no-det-order-bfsarg had no effect.Here, we refactor the det order creation to have 3 arguments:
We also eliminate
--no-det-order-bfswhich had no effect anyways.This is an example where the
--det-order-indexis faster:This is achieved via a new enum class
DetOrderin utils. It is also now exposed via python API:Fixes #103