fixing https://github.com/quantumlib/tesseract-decoder/issues/92 by updating decode_to_errors #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-visualizer-files Add visualization library to CMake build
…-and-fix-cmake-tests Fix CMake Python module path and add agent build instructions
…accept-bitstring Allow decode_to_errors to accept bitstring
NoureldinYosri
previously requested changes
Aug 20, 2025
| py::call_guard<py::scoped_ostream_redirect, py::scoped_estream_redirect>(), R"pbdoc( | ||
| .def( | ||
| "decode_to_errors", | ||
| [](TesseractDecoder& self, const py::array_t<bool>& syndrome) { |
Contributor
There was a problem hiding this comment.
I don't think it is wise to have logic in this part of the code ... having logic here should only happen for simple copying or conversion. lets either modify the C++ decode_to_errors method to have the checks and filter or create a new one that does with tests
Contributor
Author
There was a problem hiding this comment.
In a future refactor, let's add methods to the SimplexDecoder and TesseractDecoder APIs which accept a dense representation of the detection events. These will just convert to a sparse representation and call the sparse API methods. The checks for the array size can happen there instead of being duplicated throughout all the pybind glue code for both decoders. WDYT?
Co-authored-by: Noureldin <noureldinyosri@gmail.com>
noajshu
dismissed
NoureldinYosri’s stale review
just need to get this closed ASAP
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.