-
Notifications
You must be signed in to change notification settings - Fork 25
Ptool update to bring Lemans EVK support #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I reviewed the ptool diff, and it seemed fairly safe. |
|
This needs #186 first |
|
actually lemans-evk support only landed after 6.17, so switching to the backports kernel is not enough to get this in the flat build. |
2b8c901 to
2bfa0ab
Compare
|
Just a note that flat images from this PR using lemans-evk board specific files and a mainline kernel were successfully booted on a Lemans EVK (RB8) by Vivek Puar and team. |
4b6633b to
a2ffd98
Compare
|
The changes here look good, but shouldn't we have some successful LAVA test results reported? I tried to track this down, and found an RB1 failure: https://github.com/qualcomm-linux/qcom-deb-images/actions/runs/19941051119 It'd be nice to know that updating ptool doesn't regress our existing support for anything. |
|
Yes it would, not sure why the latest push didn't retrigger; the RB1 failure looks like one of our recurring infra issues, so I've given it back. |
In the current boot firmware for RB1 images, a DTB is stored in the u-boot binary which then loads the latest version from the ESP. However qcom-ptool was modified to align the partition scheme in anticipation of an upcoming switch to a regular EDK2 based firmware. Generate the dtb.bin with the correct dtb in anticipation of newer ptool and upcoming firmware. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
This brings support for new platforms and fixes for existing ones, as well as a new build-id flag for contents.xml. No architectural change. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Recent ptool versions support passing the build-id when generating contents.xml files, drop our custom logic. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Also known as IQ-9075 EVK (was RB8). This is based on QCS9100 boot binaries. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
All boards have a dtb now, drop conditionals. Signed-off-by: Loïc Minier <loic.minier@oss.qualcomm.com>
Well that did yield an important failure: I've addressed this in the newest version of the PR. |
Test jobs for commit cf30764 |
Test jobs for commit 8c2709b |
|
tests autotriggered and passed :) |
Update ptool to the latest git commit to get support for the latest boards. Take advantage of the new flag to set build-id.
Add support for Lemans EVK, also known as IQ-9075 EVK (was RB8). Confusingly, this QCS9075 EVK is using the QCS9100 boot binaries.