Skip to content

Now you can submit pressing shift+enter #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ManuelMolina97 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Now you can submit pressing shift+enter #110

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc430d1
Updated README
ManuelMolina97 Nov 4, 2017
04d4112
Just fixing issue
ManuelMolina97 Nov 4, 2017
e8b421f
Now you can save pressing shift+enter
ManuelMolina97 Nov 5, 2017
43625cd
Merge branch 'master' of https://github.com/qontu/ngx-inline-editor
ManuelMolina97 Nov 5, 2017
ccbffd2
Tried to fix logic in if statement, added type to event and calling p…
ManuelMolina97 Nov 5, 2017
113fc6b
Name given to condition, solved double checking with common factor
ManuelMolina97 Nov 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/inputs/input-textarea.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,18 @@ export class InputTextareaComponent extends InputBase implements OnInit {
}

public config: InlineTextareaConfig;

public onKeyPress(event) {
if (this.config.saveOnEnter) {
if (event.charCode === 13 && !event.shiftKey) {
this.save();
this.onEscape(event);
}
} else {
if (event.charCode === 13 && event.shiftKey) {
this.save();
this.onEscape(event);
}
Copy link
Collaborator

@Caballerog Caballerog Nov 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if and else do the same action (this.save() and this.onEscape(event)) then is not necessary if-else. You would rethink the condition using an OR operator maybe.

If you have problems with this logic, contact me and can rethink together.

}
}
}