Skip to content

Conversation

@ysiraichi
Copy link
Collaborator

This PR refactors the implementation of cat and broadcast_tensors in the tensor_methods.cpp file.
In summary:

  • Make both of them call CheckNonEmptyInputs, returning an error status on failure
  • Factor the other cat() error into its own function: CheckCatCompatibleShapes
  • Make broadcast_tensors use status constructs

Note that there are no tests for these changes because:

  • cat() is already tested
  • broadcast_tensors() is used only internally

@ysiraichi ysiraichi merged commit 520e3e8 into master Nov 10, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants