[ez][ET-VK] Update Vulkan runtime application name #16187
Merged
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2025 13:36
It seems that `choose_qparams_affine` has recently appended some arguments to the schema. This causes newly exported models to break because at runtime, the output arg can no longer be found. Fix by locating the output argument as the last entry in the args vector, rather than continuously incrementing the args index. Update quantize/dequantize ops as well since it seems quantized_decomposed namespace ops are subject to change in the future. Note that it would be good to do this for all operators in the Vulkan backend as a later refactor. Differential Revision: [D88887463](https://our.internmc.facebook.com/intern/diff/D88887463/) [ghstack-poisoned]
TSIA! Differential Revision: [D88802100](https://our.internmc.facebook.com/intern/diff/D88802100/) [ghstack-poisoned]
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16187
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 3 Unrelated FailuresAs of commit 9754870 with merge base a0a6278 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
pushed a commit
that referenced
this pull request
Dec 10, 2025
TSIA! Differential Revision: [D88802100](https://our.internmc.facebook.com/intern/diff/D88802100/) ghstack-source-id: 328515025 Pull Request resolved: #16187
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
added 2 commits
December 10, 2025 14:05
…ion name" TSIA! Differential Revision: [D88802100](https://our.internmc.facebook.com/intern/diff/D88802100/) cc manuelcandales digantdesai cbilgin [ghstack-poisoned]
TSIA! Differential Revision: [D88802100](https://our.internmc.facebook.com/intern/diff/D88802100/) cc manuelcandales digantdesai cbilgin [ghstack-poisoned]
SS-JIA
pushed a commit
that referenced
this pull request
Dec 10, 2025
Pull Request resolved: #16187 TSIA! Differential Revision: [D88802100](https://our.internmc.facebook.com/intern/diff/D88802100/) ghstack-source-id: 328525109
JacobSzwejbka
approved these changes
Dec 11, 2025
manuelcandales
approved these changes
Dec 11, 2025
SS-JIA
added a commit
that referenced
this pull request
Dec 11, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #16187 * __->__ #16186 It seems that `choose_qparams_affine` has recently appended some arguments to the schema. This causes newly exported models to break because at runtime, the output arg can no longer be found. Fix by locating the output argument as the last entry in the args vector, rather than continuously incrementing the args index. Update quantize/dequantize ops as well since it seems quantized_decomposed namespace ops are subject to change in the future. Note that it would be good to do this for all operators in the Vulkan backend as a later refactor. Differential Revision: [D88887463](https://our.internmc.facebook.com/intern/diff/D88887463/) --------- Co-authored-by: ssjia <ssjia@devvm1479.ncg0.facebook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TSIA!
Differential Revision: D88802100
cc @manuelcandales @digantdesai @cbilgin