Use SPNEGO mechanism by default #47
Conversation
|
@aiudirog could you review this? |
# Conflicts: # HISTORY.rst
|
@seowalex Thanks for the PR! Sorry for the delay, last week was pretty busy. You also reminded me that I haven't been updating HISTORY.rst, so I took care of that and then resolved the merge conflict with main. |
httpx_gssapi/gssapi_.py
Outdated
| self.opportunistic_auth = opportunistic_auth | ||
| self.creds = creds | ||
| self.mech = mech | ||
| self.mech = mech if mech else SPNEGO |
There was a problem hiding this comment.
Should we allow a user to explicitly specify mech=None to use the OS default? I could definitely see someone relying on this behavior.
There was a problem hiding this comment.
To be honest, that seems reasonable, but this was copied directly from pythongssapi/requests-gssapi#46, and I didn't understand what the considerations were for that, so I didn't feel confident in removing it.
There was a problem hiding this comment.
I think in the interest of allowing for some backwards compatibility, allowing the user to explicitly specify mech=None is a good idea.
There was a problem hiding this comment.
Makes sense, if you have other changes as well you can change that (or else I can do it).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 95.45% 95.48% +0.02%
==========================================
Files 3 3
Lines 154 155 +1
==========================================
+ Hits 147 148 +1
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Port pythongssapi/requests-gssapi#46 to
httpx-gssapi.