[stubtest] transparent @type_check_only types
#20352
Merged
+55
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
commented
Dec 2, 2025
Comment on lines
+1869
to
+1870
| msg = f"all base classes of {instance.type.fullname!r} are @type_check_only" | ||
| assert False, msg |
Contributor
Author
There was a problem hiding this comment.
I assume here that it will eventually always have encountered builtins.object before getting here.
jorenham
commented
Dec 2, 2025
Comment on lines
+1874
to
+1875
| def visit_type_alias_type(self, t: mypy.types.TypeAliasType, /) -> mypy.types.Type: | ||
| return t |
Contributor
Author
There was a problem hiding this comment.
this method might look a bit awkward, but we need it because it's marked as abstract in mypy.types.TypeTranslator (i.e., without it there'd be a squiggly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #20223 by mapping a
@type_check_onlytype (of an instance) to its first non-@type_check_onlysuperclass.A use case is for annotating specific
numpy.ufuncinstances through@type_check_onlyspecializedufuncsubtypes, as explained in #20223.