Skip to content

GH-65961: Stop setting or using __package__ on modules #142046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

GH-65961: Stop setting or using __package__ on modules #142046

wants to merge 8 commits into from

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 28, 2025 •
edited by github-actions bot
Loading

@brettcannon
Initial attempt
ff5fc7d 
```
21 tests altered the execution environment (env changed):
    test_logging test_pathlib test_profile test_pty test_pulldom
    test_pwd test_pyclbr test_pyexpat test_pyrepl test_pystats
    test_resource test_rlcompleter test_robotparser test_sax
    test_sched test_secrets test_select test_set test_shlex test_str
    test_thread

5 tests failed:
    test_capi test_cmd_line_script test_importlib test_repl
    test_sysconfig
```
@brettcannon
Fix test_importlib
d625711
@brettcannon
Merge branch 'main' of github.com:python/cpython into remove-__package__
7bfde50
@brettcannon
Fix test_cmd_line_script
ff7547f
@bedevere-app bedevere-app bot mentioned this pull request Nov 28, 2025
Open
@brettcannon
Copy link
Member Author

brettcannon commented Nov 28, 2025

Currently a draft until the test_capi failure can somehow be resolved as I have no idea how what I'm doing is the direct cause of the failure.

@brettcannon brettcannon mentioned this pull request Nov 28, 2025
Closed
@brettcannon
Copy link
Member Author

brettcannon commented Nov 28, 2025

#142055 is an alternative to this PR where __package__ is no longer set, but is still supported.

@brettcannon
Copy link
Member Author

brettcannon commented Nov 28, 2025

Yet again this project gets postponed, this time thanks to pip: https://github.com/pypa/pip/blob/36987b0c31b97ffb9fb7949ded628e9a6b10c016/src/pip/__main__.py#L13

@brettcannon
Copy link
Member Author

brettcannon commented Nov 28, 2025

The test_capi test failure is still weird, regardless, but this PR is now dead in the water.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal will be requested when the pull request is marked ready for review pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou will be requested when the pull request is marked ready for review lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv will be requested when the pull request is marked ready for review ambv is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian will be requested when the pull request is marked ready for review gaogaotiantian is a code owner

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy will be requested when the pull request is marked ready for review terryjreedy is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 will be requested when the pull request is marked ready for review 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan will be requested when the pull request is marked ready for review ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw will be requested when the pull request is marked ready for review warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brettcannon