Skip to content

gh-142029: Raise TypeError instead of crashing on empty name given to create_builtin() #142033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-142029: Raise TypeError instead of crashing on empty name given to create_builtin() #142033

wants to merge 5 commits into from

Conversation

@dr-carlos
Copy link
Contributor

@dr-carlos dr-carlos commented Nov 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 28, 2025
Open
@dr-carlos
Copy link
Contributor Author

dr-carlos commented Nov 28, 2025 •
edited
Loading

This function isn't documented or tested anywhere already, so I haven't added a test.

@sergey-miryanov
Copy link
Contributor

sergey-miryanov commented Nov 28, 2025

@dr-carlos Could you please add tests?

brettcannon
brettcannon requested changes Nov 28, 2025
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@bedevere-app
Copy link

bedevere-app bot commented Nov 28, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@dr-carlos
Copy link
Contributor Author

dr-carlos commented Nov 28, 2025 •
edited
Loading

I've added simple tests based on the errors thrown in create_builtin().

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Nov 28, 2025

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from brettcannon November 28, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

Assignees

No one assigned

Labels

awaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dr-carlos @sergey-miryanov @brettcannon