Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Lib/test/test_set.py
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,33 @@ def __hash__(self):
with self.assertRaises(KeyError):
myset.discard(elem2)

def test_set_add_to_dummy_slot(self):
# gh-141805
tasks = set()

class Dummy:
def __hash__(self):
return 0

class CorruptTrigger:
triggered = False

def __hash__(self):
return 0

def __eq__(self, value):
if not self.triggered:
self.triggered = True
tasks.add(self)
return False

tasks.add(Dummy())
tasks.add(Dummy())
tasks.pop()
self.assertEqual(len(tasks), 1)
tasks.add(CorruptTrigger())
self.assertEqual(len(tasks), 2)


class SetSubclass(set):
pass
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix set length corruption when set additions occur within
element comparison (:meth:`object.__eq__`) methods.
1 change: 1 addition & 0 deletions Objects/setobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ set_add_entry_takeref(PySetObject *so, PyObject *key, Py_hash_t hash)
else if (entry->hash == -1) {
assert (entry->key == dummy);
freeslot = entry;
goto found_unused_or_dummy;
}
entry++;
} while (probes--);
Expand Down
Loading