Skip to content

gh-141968: Use take_bytes in encodings.punycode #141974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2025
Merged

gh-141968: Use take_bytes in encodings.punycode #141974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3600bb6
gh-141968: Use take_byes in encodings.punycode
cmaloney Nov 26, 2025
69cdccc
Update Misc/NEWS.d/next/Library/2025-11-25-23-29-08.gh-issue-141968.0…
vstinner Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/encodings/punycode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def segregate(str):
else:
extended.add(c)
extended = sorted(extended)
return bytes(base), extended
return base.take_bytes(), extended

def selective_len(str, max):
"""Return the length of str, considering only characters below max."""
Expand Down Expand Up @@ -83,7 +83,7 @@ def generate_generalized_integer(N, bias):
t = T(j, bias)
if N < t:
result.append(digits[N])
return bytes(result)
return result.take_bytes()
result.append(digits[t + ((N - t) % (36 - t))])
N = (N - t) // (36 - t)
j += 1
Expand Down Expand Up @@ -112,7 +112,7 @@ def generate_integers(baselen, deltas):
s = generate_generalized_integer(delta, bias)
result.extend(s)
bias = adapt(delta, points==0, baselen+points+1)
return bytes(result)
return result.take_bytes()

def punycode_encode(text):
base, extended = segregate(text)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-11-25-23-29-08.gh-issue-141968.0JnjXf.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove data copy from :mod:`codecs` ``punycode`` encoding by using
:func:`bytearray.take_bytes`.
Loading