Skip to content

gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT #141804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2025
Merged

gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT #141804

merged 1 commit into from
Nov 24, 2025

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Nov 20, 2025 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 20, 2025
Closed
@colesbury colesbury marked this pull request as ready for review November 20, 2025 19:24
@colesbury colesbury requested a review from encukou November 20, 2025 19:24
ayushHardeniya
ayushHardeniya approved these changes Nov 20, 2025
View reviewed changes
Copy link

@ayushHardeniya ayushHardeniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

encukou
encukou approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Process nitpick: It would be nice to group this with the actual code change. Consider amending the title of gh-116749, attaching this PR to that, and marking gh-116329 as duplicate.

@colesbury colesbury changed the title gh-116329: Fix code comment for _PyConfig_GIL_DEFAULT gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT Nov 24, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 24, 2025
Closed
@colesbury colesbury merged commit c490ffb into python:main Nov 24, 2025
52 checks passed
@colesbury colesbury deleted the _PyConfig_GIL_DEFAULT branch November 24, 2025 15:42
@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 24, 2025

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
@colesbury @miss-islington
pythongh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (pythongh…
927ebe5 
…-141804)

(cherry picked from commit c490ffb)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 24, 2025

GH-141911 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
colesbury added a commit that referenced this pull request Nov 24, 2025
@miss-islington @colesbury
[3.14] gh-116749: Fix code comment for _PyConfig_GIL_DEFAULT (gh-141804…
cabaa47 
…) (gh-141911)

(cherry picked from commit c490ffb)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

+1 more reviewer

@ayushHardeniya ayushHardeniya ayushHardeniya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @encukou @ayushHardeniya