Skip to content

Conversation

@SubbaraoGarlapati
Copy link
Contributor

test.support.import_helper in Lib/test/test_monitoring.py is not actually imported in the file, relying on another import to import it. As discussed in the previous pull request, this would be fine if importing test.support itself would import test.support.import_helper but that's not the case.

% python -c "import test.support; test.support.import_helper"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    import test.support; test.support.import_helper
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'test.support' has no attribute 'import_helper'

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Nov 20, 2025
@StanFromIreland StanFromIreland changed the title Fix implicit import Fix implicit import in test_monitoring.py Nov 20, 2025
@colesbury colesbury merged commit 369ce2b into python:main Nov 24, 2025
60 checks passed
@colesbury
Copy link
Contributor

Thanks!

@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
@miss-islington-app
Copy link

Thanks @SubbaraoGarlapati for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2025
(cherry picked from commit 369ce2b)

Co-authored-by: SubbaraoGarlapati <53627478+SubbaraoGarlapati@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 24, 2025

GH-141920 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 24, 2025
colesbury pushed a commit that referenced this pull request Nov 24, 2025
…1920)

(cherry picked from commit 369ce2b)

Co-authored-by: SubbaraoGarlapati <53627478+SubbaraoGarlapati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants