gh-41779: Allow defining any __slots__ for a class derived from tuple #141763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
AA-Turner,
markshannon and
willingc
as code owners
encukou
reviewed
Nov 21, 2025
Comment on lines
+814
to
+817
| if (dmem->flags & _Py_AFTER_ITEMS) { | ||
| SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_SLOT_AFTER_ITEMS); | ||
| return -1; | ||
| } |
Member
There was a problem hiding this comment.
This looks OK but I don't know enough about the specializer to review properly.
Member
|
@markshannon Is this compatible with the laout you had in mind for the “Grand Unified Python Object Layout”? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--141763.org.readthedocs.build/