Skip to content

gh-139743: avoid print twice verbose version for sqlite tests #141618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihong0618 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-139743: avoid print twice verbose version for sqlite tests #141618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869a48a
fix: do not print the message twice in sqlite test verbose
yihong0618 Nov 16, 2025
e963e2f
fix: use global instead of pattern
yihong0618 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Lib/test/test_sqlite3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,14 @@
import os
import sqlite3

# make sure only print once
_printed_version = False

# Implement the unittest "load tests" protocol.
def load_tests(*args):
if verbose:
def load_tests(loader, tests, pattern):
global _printed_version
if verbose and not _printed_version:
print(f"test_sqlite3: testing with SQLite version {sqlite3.sqlite_version}")
_printed_version = True
pkg_dir = os.path.dirname(__file__)
return load_package_tests(pkg_dir, *args)
return load_package_tests(pkg_dir, loader, tests, pattern)
Loading