Skip to content

gh-141004: document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN #141544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 18, 2025
Merged

gh-141004: document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN #141544

merged 9 commits into from
Nov 18, 2025

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Nov 14, 2025 •
edited by github-actions bot
Loading

@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 14, 2025
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 14, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Nov 14, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 14, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Nov 14, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity approved these changes Nov 14, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not too familiar with these math APIs. @vstinner, do you want to take a look?

StanFromIreland
StanFromIreland reviewed Nov 14, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Nov 14, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding the parameters to the documentation, like is done for Py_RETURN_INF.

vstinner
vstinner reviewed Nov 14, 2025
View reviewed changes
@skirpichev @vstinner @StanFromIreland
Apply suggestions from code review
bb2bdcb 
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
skirpichev
skirpichev commented Nov 14, 2025
View reviewed changes
skirpichev
skirpichev commented Nov 14, 2025
View reviewed changes
skirpichev
skirpichev commented Nov 14, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Nov 15, 2025
View reviewed changes
@skirpichev @StanFromIreland
Apply suggestions from code review
3c5edb5 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland
StanFromIreland approved these changes Nov 16, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vstinner
vstinner reviewed Nov 17, 2025
View reviewed changes
@skirpichev skirpichev requested a review from vstinner November 17, 2025 23:05
@vstinner vstinner merged commit 630cd37 into python:main Nov 18, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 18, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 18, 2025

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 18, 2025

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 630cd37bfae0fc4021d9e9461b94d36e7ce6b95c 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Nov 18, 2025

Sorry, @skirpichev and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 630cd37bfae0fc4021d9e9461b94d36e7ce6b95c 3.13

@vstinner
Copy link
Member

vstinner commented Nov 18, 2025

Merged, thanks.

@skirpichev: Can you try to backport the change to 3.14?

@skirpichev skirpichev deleted the docs-for-math-macros/141004 branch November 18, 2025 09:35
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 18, 2025
@skirpichev @vstinner @StanFromIreland
[3.14] pythongh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS…
bdaf2b8 
…_NAN (pythonGH-141544)

(cherry picked from commit 630cd37)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2025

GH-141698 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 18, 2025
@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2025

GH-141700 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 18, 2025
skirpichev added a commit to skirpichev/cpython that referenced this pull request Nov 18, 2025
@skirpichev @vstinner @StanFromIreland
[3.14] pythongh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS…
ef704f6 
…_NAN (pythonGH-141544)

(cherry picked from commit 630cd37)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner added a commit that referenced this pull request Nov 18, 2025
@skirpichev @vstinner @StanFromIreland
[3.14] gh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN (G…
ed5c854 
…H-141544) (#141698)

(cherry picked from commit 630cd37)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner added a commit that referenced this pull request Nov 18, 2025
@skirpichev @vstinner @StanFromIreland
[3.13] gh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN (G…
a5650e4 
…H-141544) (#141700)

(cherry picked from commit 630cd37)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@vstinner vstinner

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev @vstinner @ZeroIntensity @StanFromIreland