Skip to content

gh-141536: Fix a crash when running test_capi *after* test_code in the same process #141537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yhg1s wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-141536: Fix a crash when running test_capi *after* test_code in the same process #141537

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b19275
Fix a crash when running test_capi *after* test_code in the same proc…
Yhg1s Nov 13, 2025
60e0a08
Use test.support.late_deletion instead of a sys attribute to keep the
Yhg1s Nov 18, 2025
066f3ec
Merge branch 'main' into test_code_crash
Yhg1s Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/test/test_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@
ctypes = None
from test.support import (cpython_only,
check_impl_detail, requires_debug_ranges,
gc_collect, Py_GIL_DISABLED)
gc_collect, Py_GIL_DISABLED, late_deletion)
from test.support.script_helper import assert_python_ok
from test.support import threading_helper, import_helper
from test.support.bytecode_helper import instructions_with_positions
Expand Down Expand Up @@ -1555,6 +1555,11 @@ def myfree(ptr):

FREE_FUNC = freefunc(myfree)
FREE_INDEX = RequestCodeExtraIndex(FREE_FUNC)
# Make sure myfree sticks around at least as long as the interpreter,
# since we (currently) can't unregister the function and leaving a
# dangling pointer will cause a crash on deallocation of code objects if
# something else uses co_extras, like test_capi.test_misc.
late_deletion(myfree)

class CoExtra(unittest.TestCase):
def get_func(self):
Expand Down
Loading