-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-140938: Raise ValueError for infinite inputs to stdev/pstdev #141531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+24
−5
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0d6d50c
gh-140938: Raise ValueError for infinite inputs to stdev/pstdev
rhettinger 34075e0
Trim whitespace
rhettinger 9e29e3c
Update Lib/statistics.py
rhettinger f72e1c3
Update Lib/statistics.py
rhettinger c2e821a
Update Lib/test/test_statistics.py
rhettinger e33dd4b
Update Lib/test/test_statistics.py
rhettinger a5e8ca7
Update Misc/NEWS.d/next/Library/2025-11-13-14-51-30.gh-issue-140938.k…
rhettinger b32c441
Update Misc/NEWS.d/next/Library/2025-11-13-14-51-30.gh-issue-140938.k…
gpshead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2005,7 +2005,6 @@ def test_iter_list_same(self): | |
| expected = self.func(data) | ||
| self.assertEqual(self.func(iter(data)), expected) | ||
|
|
||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this line removal wasn't intended. |
||
| class TestPVariance(VarianceStdevMixin, NumericTestCase, UnivariateTypeMixin): | ||
| # Tests for population variance. | ||
| def setUp(self): | ||
|
|
@@ -2113,6 +2112,12 @@ def test_center_not_at_mean(self): | |
| self.assertEqual(self.func(data), 2.5) | ||
| self.assertEqual(self.func(data, mu=0.5), 6.5) | ||
|
|
||
| def test_gh_140938(self): | ||
| # Inputs with math.inf should raise a ValueError | ||
rhettinger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| with self.assertRaises(ValueError): | ||
| self.func([1.0, math.inf]) | ||
rhettinger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| class TestSqrtHelpers(unittest.TestCase): | ||
|
|
||
| def test_integer_sqrt_of_frac_rto(self): | ||
|
|
||
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2025-11-13-14-51-30.gh-issue-140938.kXsHHv.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| The ``statistics.stdev`` and ``statistics.pstdev`` function now raise a | ||
gpshead marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ``ValueError`` when the input contains an infinity. | ||
rhettinger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.