Skip to content

[WIP] gh-141510: PEP 814: Add built-in frozendict type #141508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

[WIP] gh-141510: PEP 814: Add built-in frozendict type #141508

wants to merge 22 commits into from

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 13, 2025 •
edited
Loading

  • Basic tests
  • Bare minimum documentation
  • Support frozendict in marshal, pickle, json, copy
  • Replace dict with frozendict in many stdlib modules

📚 Documentation preview 📚: https://cpython-previews--141508.org.readthedocs.build/

@vstinner @corona10 @Marco-Sulla
[WIP] PEP 814: Add built-in frozendict type
1637c04 
* Basic tests
* Bare minimum documentation
* Support frozendict in marshal, pickle, json
* Replace dict with frozendict in many stdlib modules

Co-Authored-by: Donghee Na <donghee.na@python.org>
Co-Authored-by: Marco Sulla <github@marco.sulla.e4ward.com>
@vstinner vstinner changed the title [WIP] PEP 814: Add built-in frozendict type [WIP] gh-141510: PEP 814: Add built-in frozendict type Nov 13, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 13, 2025
Open
@vstinner
Copy link
Member Author

vstinner commented Nov 13, 2025

This PR was created mainly to play with PEP 814 implementation, not to be merged.

If PEP 814 is accepted, this PR should be splitted into smaller parts, easier to review.

@vstinner
Copy link
Member Author

vstinner commented Nov 13, 2025

mypy / Run mypy on Lib/_pyrepl (pull_request)
mypy / Run mypy on Lib/tomllib (pull_request)

mypy fails with Name "frozendict" is not defined.

@vstinner
Copy link
Member Author

vstinner commented Nov 13, 2025

Tests / Android (x86_64) (pull_request) does crash, I'm not sure why.

  0:01:27 [ 39/497] test.test_concurrent_futures.test_interpreter_pool
  E/libsigchain: reverting to SIG_DFL handler for signal 11, ucontext 0x72d5b7547ac0

nineteendo
nineteendo reviewed Nov 13, 2025
View reviewed changes
vstinner and others added 2 commits November 13, 2025 16:24
@vstinner
Add PyFrozenDict_Type to static_types
1a72eec
@vstinner @nineteendo
Update Doc/library/stdtypes.rst
9d6ca58 
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@vstinner vstinner mentioned this pull request Nov 13, 2025
Closed
@vstinner
Copy link
Member Author

vstinner commented Nov 13, 2025

Tests / Android (x86_64) (pull_request) does crash, I'm not sure why.

It should be fixed by Add PyFrozenDict_Type to static_types commit.

eendebakpt
eendebakpt reviewed Nov 13, 2025
View reviewed changes
eendebakpt
eendebakpt reviewed Nov 13, 2025
View reviewed changes
sergey-miryanov
sergey-miryanov reviewed Nov 14, 2025
View reviewed changes
sergey-miryanov
sergey-miryanov reviewed Nov 14, 2025
View reviewed changes
sergey-miryanov
sergey-miryanov reviewed Nov 14, 2025
View reviewed changes
sergey-miryanov
sergey-miryanov reviewed Nov 14, 2025
View reviewed changes
sergey-miryanov
sergey-miryanov reviewed Nov 14, 2025
View reviewed changes
kalvdans
kalvdans reviewed Nov 14, 2025
View reviewed changes
vstinner and others added 2 commits November 14, 2025 23:20
@vstinner @kalvdans
Update Lib/pydoc_data/topics.py
0a57448 
Co-authored-by: kalvdans <github@kalvdans.no-ip.org>
@vstinner
Fix test_copy: remove duplicated test
fc66056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov left review comments

@eendebakpt eendebakpt eendebakpt left review comments

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra will be requested when the pull request is marked ready for review JelleZijlstra is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

@encukou encukou Awaiting requested review from encukou encukou will be requested when the pull request is marked ready for review encukou is a code owner

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja hauntsaninja will be requested when the pull request is marked ready for review hauntsaninja is a code owner

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman will be requested when the pull request is marked ready for review ethanfurman is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian will be requested when the pull request is marked ready for review gaogaotiantian is a code owner

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 will be requested when the pull request is marked ready for review tomasr8 is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger will be requested when the pull request is marked ready for review rhettinger is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle will be requested when the pull request is marked ready for review pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin will be requested when the pull request is marked ready for review abalkin is a code owner

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith will be requested when the pull request is marked ready for review ericvsmith is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner

@picnixz picnixz Awaiting requested review from picnixz picnixz will be requested when the pull request is marked ready for review picnixz is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner

@methane methane Awaiting requested review from methane methane will be requested when the pull request is marked ready for review methane is a code owner

+3 more reviewers

@kalvdans kalvdans kalvdans left review comments

@Zaczero Zaczero Zaczero left review comments

@nineteendo nineteendo nineteendo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @sergey-miryanov @eendebakpt @kalvdans @Zaczero @nineteendo