Skip to content

Conversation

@Locked-chess-official
Copy link
Contributor

@Locked-chess-official Locked-chess-official commented Nov 13, 2025

Found this condition appear in "datetime.h" and "minalloc "

	modified:   Include/internal/mimalloc/mimalloc.h
	modified:   Include/internal/mimalloc/mimalloc/atomic.h
	modified:   Include/internal/mimalloc/mimalloc/internal.h
	modified:   Include/internal/mimalloc/mimalloc/prim.h
	modified:   Include/internal/mimalloc/mimalloc/track.h
	modified:   Include/internal/mimalloc/mimalloc/types.h
@sergey-miryanov
Copy link
Contributor

I'm not sure it is a good idea to do changes in mimaloc.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should touch mimalloc here, as that isn't exposed to public headers.

Edit: Sorry, missed Sergey's comment!

@Locked-chess-official
Copy link
Contributor Author

cc @ZeroIntensity
I cancel all of the change in mimaloc

@vstinner
Copy link
Member

I'm not sure it is a good idea to do changes in mimaloc.

mimalloc changes should be proposed upstream first: https://github.com/microsoft/mimalloc/.

@vstinner vstinner changed the title gh-141488:Rename macro gh-141488: Rename C API macro Nov 13, 2025
@bedevere-app
Copy link

bedevere-app bot commented Nov 14, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@vstinner vstinner enabled auto-merge (squash) November 14, 2025 10:54
@vstinner vstinner merged commit da7f4e4 into python:main Nov 14, 2025
44 checks passed
@Locked-chess-official Locked-chess-official deleted the Rename_macro branch November 15, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants