Skip to content

gh-141489: Simplify closure/freevar iteration in annotationlib._build_closure() #141490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
+1 −6
Merged

gh-141489: Simplify closure/freevar iteration in annotationlib._build_closure() #141490

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73dfb66
Simplify closure/freevar iteration in `_build_closure()`
dr-carlos Nov 13, 2025
93083ce
Raise an error if the annotate function's freevars and closure mismatch
dr-carlos Nov 13, 2025
8d498ef
Merge branch 'main' into annolib-build-closure
JelleZijlstra Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions Lib/annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,14 +844,9 @@ def call_annotate_function(annotate, format, *, owner=None, _is_evaluate=False):
def _build_closure(annotate, owner, is_class, stringifier_dict, *, allow_evaluation):
if not annotate.__closure__:
return None, None
freevars = annotate.__code__.co_freevars
new_closure = []
cell_dict = {}
for i, cell in enumerate(annotate.__closure__):
if i < len(freevars):
name = freevars[i]
else:
name = "__cell__"
for name, cell in zip(annotate.__code__.co_freevars, annotate.__closure__, strict=True):
cell_dict[name] = cell
new_cell = None
if allow_evaluation:
Expand Down
Loading