Skip to content

Conversation

@thomasballarddev
Copy link
Contributor

@thomasballarddev thomasballarddev commented Nov 3, 2025

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir labels Nov 3, 2025
@python-cla-bot
Copy link

python-cla-bot bot commented Nov 3, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@RenaudBernier
Copy link

lgtm

@StanFromIreland StanFromIreland changed the title Fix typo in socketserver documentation Docs: Fix typo in socketserver documentation Nov 3, 2025
Copy link

@MaxIngram05 MaxIngram05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@MirkoDi5 MirkoDi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this because Max told me to

@martin0024
Copy link

Lgtm

Copy link

@DudeNamedDarcy DudeNamedDarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@python python locked as spam and limited conversation to collaborators Nov 4, 2025
@StanFromIreland
Copy link
Member

I'm not sure what's going on with these approvals, they seem like spam to me, so I have locked the conversation.

@hugovk hugovk merged commit 20b64bd into python:main Nov 17, 2025
41 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 17, 2025
@hugovk hugovk added awaiting core review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting core review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 17, 2025
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 20, 2025
@python python unlocked this conversation Nov 20, 2025
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 20, 2025
@miss-islington-app
Copy link

Thanks @thomasballarddev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @thomasballarddev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2025
(cherry picked from commit 20b64bd)

Co-authored-by: Thomas Ballard <thomasballard0503@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2025

GH-141798 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2025
(cherry picked from commit 20b64bd)

Co-authored-by: Thomas Ballard <thomasballard0503@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2025

GH-141799 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 20, 2025
@python python locked and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants