Skip to content

gh-138072: Fix typos and grammatical errors and improve clarity in asyncio howto document #138895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 4 commits into from
Oct 14, 2025
Merged

gh-138072: Fix typos and grammatical errors and improve clarity in asyncio howto document #138895

hugovk merged 4 commits into from
Oct 14, 2025

Conversation

@Morteza-24
Copy link
Contributor

@Morteza-24 Morteza-24 commented Sep 14, 2025 •
edited by bedevere-app bot
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented Sep 14, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 14, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Sep 14, 2025
@StanFromIreland StanFromIreland requested review from ZeroIntensity and kumaraditya303 and removed request for ZeroIntensity September 14, 2025 19:56
@StanFromIreland
Copy link
Member

StanFromIreland commented Sep 14, 2025

cc @anordin95

@StanFromIreland StanFromIreland changed the title Fix typos and grammatical errors and improve clarity in asyncio howto document gh-138072: Fix typos and grammatical errors and improve clarity in asyncio howto document Sep 14, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 14, 2025
Closed
@StanFromIreland
Copy link
Member

StanFromIreland commented Sep 14, 2025

Some changes may conflict with other open prs #138073 and #138200

anordin95
anordin95 reviewed Sep 14, 2025
View reviewed changes
anordin95
anordin95 reviewed Sep 15, 2025
View reviewed changes
anordin95
anordin95 reviewed Sep 15, 2025
View reviewed changes
anordin95
anordin95 reviewed Sep 15, 2025
View reviewed changes
@anordin95
Copy link
Contributor

anordin95 commented Sep 15, 2025

@Morteza-24, thank you for the careful catches and improvements! I left a few comments regarding some minor changes I'd like to see, but otherwise this looks good to me :)

@anordin95
Copy link
Contributor

anordin95 commented Sep 15, 2025

Some changes may conflict with other open prs #138073 and #138200

Mhm, good call out! I think we should just merge whenever a PR is approved, to avoid any headache associated with tracking which to merge first, and other PRs should accommodate as needed.

@Morteza-24
Copy link
Contributor Author

Morteza-24 commented Sep 15, 2025

@anordin95, thanks for the review! I’ve addressed your comments in new commits.

@anordin95
Copy link
Contributor

anordin95 commented Sep 15, 2025

Of course! This looks good to me. For reference, you will have to wait for a core dev to do a review (and approve) before merging.

ilovelinux
ilovelinux approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@ilovelinux ilovelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely clearer now. Thanks!

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 15, 2025
@hugovk hugovk merged commit 362fd59 into python:main Oct 14, 2025
35 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 14, 2025

Thanks @Morteza-24 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Oct 14, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2025
@Morteza-24 @miss-islington
pythongh-138072: Fix typos and grammatical errors and improve clarity…
69b4ad0 
… in asyncio howto document (pythonGH-138895)

(cherry picked from commit 362fd59)

Co-authored-by: Morteza24 <mortezia4444.mz@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2025
@Morteza-24 @miss-islington
pythongh-138072: Fix typos and grammatical errors and improve clarity…
9a934cd 
… in asyncio howto document (pythonGH-138895)

(cherry picked from commit 362fd59)

Co-authored-by: Morteza24 <mortezia4444.mz@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 14, 2025

GH-140091 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 14, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 14, 2025

GH-140092 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 14, 2025
hugovk pushed a commit that referenced this pull request Oct 14, 2025
@miss-islington @Morteza-24
[3.13] gh-138072: Fix typos and grammatical errors and improve clarit…
eec807a 
…y in asyncio howto document (GH-138895) (#140092)

Co-authored-by: Morteza24 <mortezia4444.mz@gmail.com>
hugovk pushed a commit that referenced this pull request Oct 14, 2025
@miss-islington @Morteza-24
[3.14] gh-138072: Fix typos and grammatical errors and improve clarit…
b0c92e4 
…y in asyncio howto document (GH-138895) (#140091)

Co-authored-by: Morteza24 <mortezia4444.mz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

+2 more reviewers

@anordin95 anordin95 anordin95 left review comments

@ilovelinux ilovelinux ilovelinux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Morteza-24 @StanFromIreland @anordin95 @ilovelinux @ZeroIntensity @hugovk