Skip to content

gh-138669: Increase test coverage for difflib #138670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 4 commits into from
Sep 12, 2025
Merged

gh-138669: Increase test coverage for difflib #138670

encukou merged 4 commits into from
Sep 12, 2025

Conversation

@JanEricNitschke
Copy link
Contributor

@JanEricNitschke JanEricNitschke commented Sep 8, 2025 •
edited
Loading

Previously:

Name             Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------
Lib/difflib.py     677     19    328     21    96%   523, 697, 699, 865, 867, 871, 885-886, 974, 978, 1061, 1150->1157, 1170->1162, 1239->1246, 1252->1258, 1261->1238, 1263->1262, 1447, 1514-1516, 1526->1532, 1814-1815, 1981->1984, 2090-2091
------------------------------------------------------------
TOTAL              677     19    328     21    96%

Now:

Name             Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------
Lib/difflib.py     677     12    328     16    97%   871, 885-886, 974, 978, 1061, 1150->1157, 1170->1162, 1239->1246, 1252->1258, 1261->1238, 1263->1262, 1447, 1514-1516, 1526->1532, 1814-1815, 1981->1984
------------------------------------------------------------
TOTAL              677     12    328     16    97%

I thought about also testing the "pat" argument for IS_LINE_JUNK, but decided against it because it is completely undocumented.

Additionally i considered adding the raising tests to the doctests, but decided against that to keep them concise.

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 8, 2025
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app bot mentioned this pull request Sep 8, 2025
Closed
@StanFromIreland StanFromIreland mentioned this pull request Sep 8, 2025
Open
encukou
encukou reviewed Sep 9, 2025
View reviewed changes
encukou
encukou approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment to avoid implying that users can rely on opcodes being the same object.

Otherwise, this looks great! Thank you!

@JanEricNitschke @encukou
Add comment that caching is an implementation detail
9663729 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou merged commit 4499161 into python:main Sep 12, 2025
43 checks passed
@encukou encukou added the needs backport to 3.14 bugs and security fixes label Sep 12, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 12, 2025

Thanks @JanEricNitschke for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@encukou encukou added the needs backport to 3.13 bugs and security fixes label Sep 12, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 12, 2025

Thanks @JanEricNitschke for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2025
@JanEricNitschke @miss-islington
pythongh-138669: Increase test coverage for difflib (pythonGH-138670)
363b85e 
(cherry picked from commit 4499161)

Co-authored-by: Jan-Eric Nitschke <47750513+JanEricNitschke@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2025
@JanEricNitschke @miss-islington
pythongh-138669: Increase test coverage for difflib (pythonGH-138670)
af203bd 
(cherry picked from commit 4499161)

Co-authored-by: Jan-Eric Nitschke <47750513+JanEricNitschke@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2025

GH-138817 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 12, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2025

GH-138818 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 12, 2025
gpshead pushed a commit that referenced this pull request Sep 14, 2025
@miss-islington @JanEricNitschke
[3.13] gh-138669: Increase test coverage for difflib (GH-138670) (#13…
d8d11d5 
…8818)

gh-138669: Increase test coverage for difflib (GH-138670)
(cherry picked from commit 4499161)

Co-authored-by: Jan-Eric Nitschke <47750513+JanEricNitschke@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Sep 14, 2025
@miss-islington @JanEricNitschke
[3.14] gh-138669: Increase test coverage for difflib (GH-138670) (#13…
80e59a8 
…8817)

Co-authored-by: Jan-Eric Nitschke <47750513+JanEricNitschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JanEricNitschke @encukou @StanFromIreland