gh-138257: Fix internal RuleCollectorVisitor attribute name
#138208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nybblista
approved these changes
Aug 27, 2025
skirpichev
approved these changes
Aug 28, 2025
StanFromIreland
approved these changes
Aug 30, 2025
picnixz
changed the title
Tools/peg_generator/pegen/parser_generator.py
picnixz
changed the title
Tools/peg_generator/pegen/parser_generator.pyTools/peg_generator/pegen/parser_generator.py
Member
|
I want an issue for this, just for posterity. I'm creating one. |
picnixz
changed the title
Tools/peg_generator/pegen/parser_generator.pyRuleCollectorVisitor attribute name
Member
In general, they don't but only if they are documentation-oriented. Runtime changes do need an issue for tracking purposes and so that others can reply to the issue if this changed something for them. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StanFromIreland
added
needs backport to 3.13
|
Thanks @chemelnucfin for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2025
…ythonGH-138208) The internal `RuleCollectorVisitor` class had an attribute named "rulses" instead of "rules" that other `GrammarVisitor` subclasses define. (cherry picked from commit 11217a8) Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 30, 2025
…ythonGH-138208) The internal `RuleCollectorVisitor` class had an attribute named "rulses" instead of "rules" that other `GrammarVisitor` subclasses define. (cherry picked from commit 11217a8) Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
|
GH-138259 is a backport of this pull request to the 3.14 branch. |
|
GH-138260 is a backport of this pull request to the 3.13 branch. |
picnixz
pushed a commit
that referenced
this pull request
Aug 30, 2025
…H-138208) (#138260) gh-138257: Fix internal `RuleCollectorVisitor` attribute name (GH-138208) The internal `RuleCollectorVisitor` class had an attribute named "rulses" instead of "rules" that other `GrammarVisitor` subclasses define. (cherry picked from commit 11217a8) Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
… name (pythonGH-138208) (python#138259) Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…ython#138208) The internal `RuleCollectorVisitor` class had an attribute named "rulses" instead of "rules" that other `GrammarVisitor` subclasses define.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial changes, like fixing a typo, do not need an issue.
Typo in
parser_generator. Not used anywhere elseRuleCollectorVisitor.rulsesattribute #138257