-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
GH-137841: Open tzdata/zones file with UTF-8 encoding #137872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
auvipy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes make sense. and looks good
|
Is it worth backporting this? |
|
I think it should be backported to python 3.14 |
|
Can we get this backported to Python 3.14 please? |
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
GH-141607 is a backport of this pull request to the 3.14 branch. |
|
GH-141608 is a backport of this pull request to the 3.13 branch. |
zoneinfo.available_timezones()emitsEncodingWarningon python 3.11+ ifftzdatais installed and-X warn_default_encodingis used #137841