gh-134160: Block multiple module initialization #134773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There's a better way to do this, but module state might work better in Chapter 2? |
neonene
reviewed
May 27, 2025
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
I just realized that we don't have any dedicated section on subinterpreters. I'd be happy to do that in a follow-up.
Co-authored-by: Petr Viktorin <encukou@gmail.com>
AA-Turner
reviewed
May 27, 2025
AA-Turner
reviewed
May 27, 2025
AA-Turner
approved these changes
May 27, 2025
Member
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
Two very minor suggestions, but otherwise let's get this merged quickly.
A
AA-Turner
added
needs backport to 3.13
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Thanks @encukou for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2025
(cherry picked from commit 469a564) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2025
(cherry picked from commit 469a564) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-134827 is a backport of this pull request to the 3.14 branch. |
|
GH-134828 is a backport of this pull request to the 3.13 branch. |
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the tutorial to block multiple module initialization, and note the reference leak.
📚 Documentation preview 📚: https://cpython-previews--134773.org.readthedocs.build/