Skip to content

gh-134693: Fix [-Wmaybe-uninitialized] warning in _remote_debugging_module.c #134694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

gh-134693: Fix [-Wmaybe-uninitialized] warning in _remote_debugging_module.c #134694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d34aba3
gh-134693: Fix `[-Wmaybe-uninitialized]` warning in `_remote_debuggin…
sobolevn May 26, 2025
1dde61f
Merge branch 'main' into issue-134693
sobolevn May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions Modules/_remote_debugging_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,6 +1875,14 @@ parse_async_frame_object(

*previous_frame = GET_MEMBER(uintptr_t, frame, unwinder->debug_offsets.interpreter_frame.previous);

*code_object = GET_MEMBER(uintptr_t, frame, unwinder->debug_offsets.interpreter_frame.executable);
// Strip tag bits for consistent comparison
*code_object &= ~Py_TAG_BITS;
assert(code_object != NULL);
if ((void*)*code_object == NULL) {
return 0;
}

if (GET_MEMBER(char, frame, unwinder->debug_offsets.interpreter_frame.owner) == FRAME_OWNED_BY_CSTACK ||
GET_MEMBER(char, frame, unwinder->debug_offsets.interpreter_frame.owner) == FRAME_OWNED_BY_INTERPRETER) {
return 0; // C frame
Expand All @@ -1887,15 +1895,6 @@ parse_async_frame_object(
return -1;
}

*code_object = GET_MEMBER(uintptr_t, frame, unwinder->debug_offsets.interpreter_frame.executable);
// Strip tag bits for consistent comparison
*code_object &= ~Py_TAG_BITS;

assert(code_object != NULL);
if ((void*)*code_object == NULL) {
return 0;
}

uintptr_t instruction_pointer = GET_MEMBER(uintptr_t, frame, unwinder->debug_offsets.interpreter_frame.instr_ptr);

// Get tlbc_index for free threading builds
Expand Down
Loading