Skip to content

gh-131338: Disable new stack size code for non-glibc on linux. #134336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 28, 2025
Merged

gh-131338: Disable new stack size code for non-glibc on linux. #134336

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d8f676
Disable new stack size code for non-glibc.
bitdancer May 20, 2025
d7262cc
Don't require glibc if it isn't linux.
bitdancer Jun 15, 2025
5c55790
Clarify why we check __glibc__.
bitdancer Jun 16, 2025
ac92003
Apply suggestion from @vstinner
kumaraditya303 Jul 25, 2025
733a28b
add news
kumaraditya303 Jul 25, 2025
6498d29
Merge branch 'main' into revert_new_stack_check_for_non_glibc-131338
kumaraditya303 Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,8 @@ _Py_InitializeRecursionLimits(PyThreadState *tstate)
_tstate->c_stack_soft_limit = _tstate->c_stack_hard_limit + PYOS_STACK_MARGIN_BYTES;
#else
uintptr_t here_addr = _Py_get_machine_stack_pointer();
# if defined(HAVE_PTHREAD_GETATTR_NP) && !defined(_AIX) && !defined(__NetBSD__)
# if defined(HAVE_PTHREAD_GETATTR_NP) && !defined(_AIX) && \
!defined(__NetBSD__) && defined(__GLIBC__)
Copy link
Member

@vstinner vstinner May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this call is correct. It disables the call on FreeBSD.

Maybe check for "glibc or not Linux"?

Copy link
Member Author

@bitdancer bitdancer Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would fix it for alpine, but not for emscripten or wasi (but I don't know what they actually need). I'd rather see it as if glibc or freebsd, and get rid of the rest, but glibc or not linux would work for my immediate concern.

Copy link
Member

@vstinner vstinner Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, let's start with fixing Alpine Linux.

Copy link
Member Author

@bitdancer bitdancer Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done. Also added an XXX comment, since I think this needs more investigation. I'll put it on my todo list to post to the musl mailing list about it.

size_t stack_size, guard_size;
void *stack_addr;
pthread_attr_t attr;
Expand Down
Loading