gh-62824: Add alias for iso-8859-8-i which is the same as iso-8859-8 #134306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Based on @malemburg's comment on #32279, I'm landing this. |
|
Thanks @basbloemsaat for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2025
…859-8 (pythongh-134306) (cherry picked from commit 5ab66a8) Co-authored-by: Bas Bloemsaat <bas@bloemsaat.com> Co-authored-by: David Goncalves <davegoncalves@gmail.com> Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
|
GH-134330 is a backport of this pull request to the 3.14 branch. |
hroncok
reviewed
May 27, 2025
Comment on lines
+3111
to
+3116
| def test_alias_modules_exist(self): | ||
| encodings_dir = os.path.dirname(encodings.__file__) | ||
| for value in encodings.aliases.aliases.values(): | ||
| codec_file = os.path.join(encodings_dir, value + ".py") | ||
| self.assertTrue(os.path.isfile(codec_file), | ||
| "Codec file not found: " + codec_file) |
Contributor
There was a problem hiding this comment.
A follow-up for this test: #134777
We see failures when running this in Fedora with installed Python 3.14.0b2.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…859-8 (pythongh-134306) Co-authored-by: David Goncalves <davegoncalves@gmail.com> Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…859-8 (pythongh-134306) Co-authored-by: David Goncalves <davegoncalves@gmail.com> Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.