gh-131798: JIT: Split CALL_STR_1 into several uops #132849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
commented
Apr 24, 2025
Comment on lines
859
to
863
| if (sym_matches_type(arg, &PyUnicode_Type)) { | ||
| // e.g. str('foo') or str(foo) where foo is known to be a string | ||
| PyObject *value = sym_get_const(ctx, arg); | ||
| res = sym_new_const(ctx, value); | ||
| } |
Member
Author
There was a problem hiding this comment.
This is an optimization that Brandt suggested. When in str(foo), foo is known to be a string, we can propagate it to the output. I also added a test for this case.
brandtbucher
approved these changes
Apr 24, 2025
Member
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Looks great! Just two suggestions:
Member
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CALL_STR_1is equivalent tostr(...).Very similar to previous work on splitting up
CALL_TYPE_1: #132419This splits the instruction into a smaller instruction + 2 guards which can be optimized away. This also sets the return type to
str.