Skip to content

Fix Python 3.12+, Tornado 6.3+ event loop deprecation warnings #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martindurant merged 4 commits into from
Dec 18, 2025
Merged

Fix Python 3.12+, Tornado 6.3+ event loop deprecation warnings #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1220b7c
Remove IOLoop.clear_instance from utils_test.py
dwskoog Dec 16, 2025
feb649d
Remove explicit IOLoop.make_current in utils_test
dwskoog Dec 16, 2025
0b0f41a
Remove explicit use of IOLoop.clear_current()
dwskoog Dec 16, 2025
0783d91
Fix several "no active event loop" warnings
dwskoog Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion streamz/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def get_io_loop(asynchronous=None):
return client.loop

if not _io_loops:
loop = IOLoop()
loop = IOLoop(make_current=False)
thread = threading.Thread(target=loop.start)
thread.daemon = True
thread.start()
Expand Down
3 changes: 2 additions & 1 deletion streamz/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,8 @@ def test_timed_window_metadata():
]


def test_timed_window_timedelta(clean): # noqa: F811
@pytest.mark.asyncio
async def test_timed_window_timedelta(clean): # noqa: F811
pytest.importorskip('pandas')
source = Stream(asynchronous=True)
a = source.timed_window('10ms')
Expand Down
7 changes: 1 addition & 6 deletions streamz/utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,11 @@ def double(x):

@contextmanager
def pristine_loop():
IOLoop.clear_instance()
IOLoop.clear_current()
loop = IOLoop()
loop.make_current()
loop = IOLoop(make_current=False)
try:
yield loop
finally:
loop.close(all_fds=True)
IOLoop.clear_instance()
IOLoop.clear_current()


def gen_test(timeout=10):
Expand Down
Loading