Add PyCDFpp package #423
Merged
Add PyCDFpp package #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
reviewed
Dec 7, 2025
packages/pycdfpp/meta.yaml
Outdated
| sha256: 7076cf165a6bdbd4648b863676ca293f8251d660f5a2f2aa2b15acc4737023fe | ||
|
|
||
| build: | ||
| cross-build-env: true |
packages/pycdfpp/meta.yaml
Outdated
| top-level: | ||
| - pycdfpp | ||
| source: | ||
| url: https://github.com/SciQLop/CDFpp/archive/refs/tags/v0.8.3.tar.gz |
Member
There was a problem hiding this comment.
We prefer downloading the wheel from PyPI rather than from GitHub commit. It seems like you don't upload Package sdist to PyPI, is there some reason behind it?
Contributor
Author
There was a problem hiding this comment.
I do but the PyPI push is broken since last week, I'll fix this today.
packages/pycdfpp/test_pycdfpp.py
Outdated
| def test_pycdfpp(selenium): | ||
| import pycdfpp | ||
| import requests | ||
| cdf = pycdfpp.load(requests.get('https://cdaweb.gsfc.nasa.gov/pub/software/cdawlib/0MASTERS/a1_k0_mpa_00000000_v01.cdf').content) |
Member
There was a problem hiding this comment.
Could you change the unittest so that we don't make requests to an external website everytime? I think you can make a very small test file and load it from the filesystem instead.
jeandet
force-pushed
the
add_pycdfpp
branch
2 times, most recently
from
f75879a to
e778023
Compare
Contributor
Package Build ResultsTotal packages built: 31 Package Build Times (click to expand)
Longest build: libopenssl (4m 19s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.