Skip to content

Ignore -headerpad_max_install_names and -dead_strip_dylibs for wasm-ld #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agriyakhetarpal merged 1 commit into from
Jun 30, 2025
Merged

Ignore -headerpad_max_install_names and -dead_strip_dylibs for wasm-ld #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyodide_build/pywasmcross.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ def replay_genargs_handle_linker_opts(arg: str) -> str | None:
# wasm-ld does not recognize some link flags
"--sort-common",
"--as-needed",
# macOS-specific linker flags that wasm-ld doesn't understand
"-headerpad_max_install_names",
"-dead_strip_dylibs",
]:
Copy link
Member

@ryanking13 ryanking13 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not related to this PR, but I think we can do some micro optimization here:

  1. Let's change the list to a set for fast check
  2. Initialize the set before for loop

Copy link
Member Author

@agriyakhetarpal agriyakhetarpal Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that makes sense. I'll take that up in a new PR!

continue

Expand Down