Validate compatible linker in Scan Python/C backend #1757
+147
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
scan_temp
branch
2 times, most recently
from
6117510 to
d804376
Compare
ricardoV94
force-pushed
the
scan_temp
branch
from
d804376 to
65a903b
Compare
ricardoV94
changed the title
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge case found out in #811
Scan with preallocated mitmot outputs do not execute correctly in the Python/Cython implementations unless the inner function is compilde with a VMLinker which can perform updates automatically.
The whole mode in Scan should be phased out, but for now we make sure things work correctly.
Also added a few more rewrite compatibility to linkers that I missed in #1746