Replace OTel events with logs #3641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the deprecated OpenTelemetry events SDK with the logs SDK. The changes update imports, class names, and method calls throughout the codebase to use LogRecord and LoggerProvider instead of Event and EventLoggerProvider.
Key changes:
- Replaced
opentelemetry._eventsimports withopentelemetry._logsequivalents - Updated
Eventreferences toLogRecordwithattributes={'event.name': ...}pattern - Changed parameter names from
event_logger_providertologger_provider
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/models/test_instrumented.py | Updated imports and test assertions to reflect LogRecord changes; severity_number now None instead of 9 |
| tests/models/test_fallback.py | Added logfire.exception.fingerprint to test expectations |
| pydantic_ai_slim/pydantic_ai/models/instrumented.py | Replaced Event with LogRecord, updated InstrumentationSettings to use Logger/LoggerProvider |
| pydantic_ai_slim/pydantic_ai/messages.py | Updated message parts to return LogRecord instead of Event with event.name in attributes |
| docs/logfire.md | Updated documentation references from EventLoggerProvider to LoggerProvider |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events SDK has been deprecated.