pass container id back #3637
Open
pass container id back #3637
+160
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrandman
force-pushed
the
container-id
branch
2 times, most recently
from
aa4dca2 to
4cc56e5
Compare
mattbrandman
force-pushed
the
container-id
branch
from
4cc56e5 to
b713ad3
Compare
Contributor
Author
|
@DouweM for review whenever you have time |
DouweM
requested changes
Dec 4, 2025
| return None if container is False else container | ||
| for m in reversed(messages): | ||
| if isinstance(m, ModelResponse) and m.provider_details: | ||
| if cid := m.provider_details.get('container_id'): |
Collaborator
There was a problem hiding this comment.
We should verify that the provider_name matches self.system as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves containerid part of #3365.