Further e2e test improvements #2801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrbradley
force-pushed
the
e2e-tests
branch
from
ba605ac to
aa7aa8c
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
danielrbradley
force-pushed
the
e2e-tests
branch
3 times, most recently
from
cc1e50e to
d51eb50
Compare
- Make: Skip expanding then passing the list of go packages. `./...` does this for us. - Use gotestfmt in CI/CD for better output. Still set same coverage flags as in make. - Combine provider and arm2pulumi prebuild steps to make CI prebuild easier. - Increase explicit `-parallel` from program test in CI to 16. Tests are not bound on local resources but rather on waiting for external services. - Add actionlint.yaml config to silence warnings about self-hosted runners.
Add `Additive: true` because otherwise the second step fails with: error: PULUMI_ACCESS_TOKEN must be set for login during non-interactive CLI sessions Seems to be related to a historic regression: pulumi/pulumi#12859
danielrbradley
force-pushed
the
e2e-tests
branch
from
d51eb50 to
73963ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2801 +/- ##
==========================================
+ Coverage 58.54% 58.80% +0.26%
==========================================
Files 53 53
Lines 9875 9909 +34
==========================================
+ Hits 5781 5827 +46
+ Misses 3577 3559 -18
- Partials 517 523 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./...does this for us.-parallelfrom program test in CI to 16. Tests are not bound on local resources but rather on waiting for external services.