Skip to content

Do not ignore descriptor extensions #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

Do not ignore descriptor extensions #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions generator/js_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,20 +430,12 @@ std::string GetEnumFileName(const GeneratorOptions& options,
// Returns the message/response ID, if set.
std::string GetMessageId(const Descriptor* desc) { return std::string(); }

bool IgnoreExtensionField(const FieldDescriptor* field) {
// Exclude descriptor extensions from output "to avoid clutter" (from original
// codegen).
if (!field->is_extension()) return false;
const FileDescriptor* file = field->containing_type()->file();
return file->name() == "net/proto2/proto/descriptor.proto" ||
file->name() == "google/protobuf/descriptor.proto";
}

// Used inside Google only -- do not remove.
bool IsResponse(const Descriptor* desc) { return false; }

bool IgnoreField(const FieldDescriptor* field) {
return IgnoreExtensionField(field);
// no-op in open source
return false;
}

// Do we ignore this message type?
Expand Down
1 change: 1 addition & 0 deletions jasmine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"google/protobuf/any.js",
"google/protobuf/struct.js",
"google/protobuf/timestamp.js",
"google/protobuf/descriptor.js",
"testproto_libs1.js",
"testproto_libs2.js"
]
Expand Down