Backport binary proto serialization/deserialization changes and enable protobuf Editions #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibenede
force-pushed
the
editions
branch
2 times, most recently
from
a3e197c to
8c50065
Compare
varomodt
reviewed
Jul 22, 2025
dibenede
force-pushed
the
editions
branch
3 times, most recently
from
ecea63c to
179001d
Compare
varomodt
approved these changes
Jul 23, 2025
Contributor
varomodt
left a comment
varomodt
left a comment
There was a problem hiding this comment.
LG, please squash these commits
This change backports our binary serialization/deserialization code. The newer code includes several years worth of improvements that improve the overall conformance findings. The improved state of things allows us to enable protobuf edition 2023. Other items: - Add missing export annotation for BinaryReader.readStringRequireUtf8 - promote protobuf conformance testing client to main directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.