Add missing documentation for ILM metrics #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Ballet <jon@multani.info>
Signed-off-by: Jonathan Ballet <jon@multani.info>
sysadmind
requested changes
Dec 14, 2024
Contributor
sysadmind
left a comment
sysadmind
left a comment
There was a problem hiding this comment.
Thanks for the PR, just a small cleanup to be consistent with the rest.
multani
commented
Feb 13, 2025
Signed-off-by: Jonathan Ballet <jon@multani.info>
sysadmind
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#513 added the metrics but they were not documented.
I'm not sure about the "cardinality" content ; this is my understanding:
elasticsearch_ilm_statushas anoperation_modelabel which can have 3 values so I set cardinality to3elasticsearch_ilm_index_statushas more labels, in particularindexwhich can be unbounded, so I didn't set any cardinality (since it depends on the number of indices in the cluster).