Update tests for the snapshot collector #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prepare for the conversion of the snapshot collector to the collector interface, update the tests to test the metric output. - Remove the up, totalScrapes, and jsonParseFailures metrics. These won't be used after conversion to the collector interface. - Fix `Describe()` including the repositoryMetrics to pass tests - Break test fixtures out to individual files Signed-off-by: Joe Adams <github@joeadams.io>
SuperQ
approved these changes
Oct 11, 2023
jaimeyh
pushed a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
To prepare for the conversion of the snapshot collector to the collector interface, update the tests to test the metric output. - Remove the up, totalScrapes, and jsonParseFailures metrics. These won't be used after conversion to the collector interface. - Fix `Describe()` including the repositoryMetrics to pass tests - Break test fixtures out to individual files Signed-off-by: Joe Adams <github@joeadams.io>
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for the conversion of the snapshot collector to the collector interface, update the tests to test the metric output.
Describe()including the repositoryMetrics to pass tests