Add extra tests and improve error handling in watermark metrics #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @tomachine |
Improve the error handling for watermark metrics. When we have an error, do not report a 0 value for the metric. Adds tests for parsing the ratio/percentage and the human readable bytes in watermark data. Functionality originally added in prometheus-community#611 Signed-off-by: Joe Adams <github@joeadams.io>
sysadmind
force-pushed
the
611-cleanup
branch
from
97bf983 to
3d61697
Compare
jaimeyh
pushed a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
…etheus-community#752) Improve the error handling for watermark metrics. When we have an error, do not report a 0 value for the metric. Adds tests for parsing the ratio/percentage and the human readable bytes in watermark data. Functionality originally added in prometheus-community#611 Signed-off-by: Joe Adams <github@joeadams.io>
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
…cs (prometheus-community#752)" This reverts commit cd74247.
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
…cs (prometheus-community#752)" This reverts commit cd74247.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the error handling for watermark metrics. When we have an error, do not report a 0 value for the metric.
Adds tests for parsing the ratio/percentage and the human readable bytes in watermark data.
Functionality originally added in #611