feat: add node label on elasticsearch_nodes_roles metric #1106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Elasticsearch nodes roles metric to include the unique node ID as a label. This provides better identification and disambiguation of nodes with the same name or host, improving the accuracy of monitoring and troubleshooting. The change is reflected in both the metric generation code and the corresponding test cases.
Metrics and Labeling Improvements:
nodelabel (containing the node ID) to theelasticsearch_nodes_rolesmetric, updating thedefaultRoleLabelsarray incollector/nodes.goto include"node".elasticsearch_nodes_rolesmetric. [1] [2]Testing Updates:
collector/nodes_test.goto expect the newnodelabel in allelasticsearch_nodes_rolesmetric outputs, ensuring tests accurately reflect the new metric format. [1] [2] [3]