Fix memleak for create a TimeTicker without stop #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysadmind
requested changes
Jun 11, 2025
Contributor
sysadmind
left a comment
sysadmind
left a comment
There was a problem hiding this comment.
This commit needs the DCO to pass checks. You should be able to git commit --ammend --signoff.
While I agree that this change is positive, I don't think this will solve a memory problem. The Run function is only ever called once from main.go, so I don't see how we could make multiple timers. I suspect something else is going on here. Really glad to see that pprof is helping here!
Signed-off-by: YenchangChan <chenyanchang1990@163.com>
sysadmind
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1048 memleak for create a TimeTicker without stop