feat: add support for _health_report #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardklose
force-pushed
the
feat/health_report
branch
from
910c31e to
17cc0a2
Compare
|
cool, this will greatly improve our elasticsearch monitoring! Would be great if someone could review it. |
sysadmind
reviewed
Feb 23, 2025
sysadmind
reviewed
Feb 23, 2025
sysadmind
requested changes
Feb 23, 2025
Contributor
|
See the SLM collector for a good example of how we currently implement collectors |
richardklose
force-pushed
the
feat/health_report
branch
2 times, most recently
from
55c1f6f to
6a0bb0e
Compare
Contributor
Author
|
@sysadmind I refactored the collector and tried to stick with how the SLM collector is implemented. Not sure how to deal with the many status colors there, so I'll appreciate any suggestions for improvements on that. |
sysadmind
requested changes
Mar 5, 2025
sysadmind
reviewed
Mar 5, 2025
richardklose
force-pushed
the
feat/health_report
branch
2 times, most recently
from
c010d5c to
1ed57bc
Compare
In elasticsearch 8.7 a new endpoint for cluster health has been added. See https://www.elastic.co/docs/api/doc/elasticsearch/v8/operation/operation-health-report Signed-off-by: Richard Klose <richard.klose@wiit.cloud>
richardklose
force-pushed
the
feat/health_report
branch
from
1ed57bc to
f6b5497
Compare
sysadmind
requested changes
Mar 18, 2025
Contributor
sysadmind
left a comment
sysadmind
left a comment
There was a problem hiding this comment.
I think functionally this is all good now, just need to fix the cardinality numbers on some metrics in the docs and update the version added to match the next release
Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Richard Klose <richard@klose.dev>
sysadmind
approved these changes
Apr 2, 2025
Contributor
Author
|
@sysadmind Can you provide a 1.10 release via Github that includes this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In elasticsearch 8.7 a new endpoint for cluster health has been added. See https://www.elastic.co/docs/api/doc/elasticsearch/v8/operation/operation-health-report